RETROBAT Official Board
Would you like to react to this message? Create an account in a few clicks or log in to continue.

Quality of life issues for Retrobat

2 posters

Go down

Quality of life issues for Retrobat Empty Quality of life issues for Retrobat

Post by RetroNoob2024 06/07/24, 09:46 pm

Just discovered the retrobat version of emulation station and what a blast!!!! The performance is amazing compared to what I used to have.

Now I discovered some minor things that I wish were part of this version that I lost.

1. Case sensitive extensions. This was a very convenient way to hide files, bios, etc. Even the retropie version reversed it (https://github.com/RetroPie/EmulationStation/pull/833). To be clear this is NOT a windows issue, it works perfectly fine without the linux filesystem on windows, it is just that the code in retrobat added specific code to make it case insensitive.

In batocera-emulationstation/es-app/src/SystemData.cpp in SystemData* SystemData::loadSystem(pugi::xml_node system, bool fullMode)
for example std::string extlow = Utils::String::toLower(ext);

and in PopulateFolder too for example extension = Utils::String::toLower(Utils::FileSystem::getExtension(filePath));

Now I understand changing this behavior now could create chaos for everyone so here is my request: Could a developer option be added to NOT make the extensions case insensitive?

2. Image and video filtering. Images and videos do not have any filtering applied when rescaled which creates some aliasing. Is it possible to either add the filtering option per theme in the md_video or md_image settings? maybe something like <filteringMode>bilinear</filteringMode> would be awesome.

P.S. I would gladly make those changes on my branch of the code if it was available but it seems the code is not available in github. Maybe someone can point me to how to get the code and compile it?
RetroNoob2024
RetroNoob2024

Messages : 4
Date d'inscription : 2024-07-06

Back to top Go down

Quality of life issues for Retrobat Empty Re: Quality of life issues for Retrobat

Post by tartifless 06/07/24, 09:56 pm

Emulationstation is available on batocera github.
We use the same.


Quality of life issues for Retrobat Admin4
tartifless
tartifless
Admin

Messages : 1674
Date d'inscription : 2021-04-27

Back to top Go down

Quality of life issues for Retrobat Empty Re: Quality of life issues for Retrobat

Post by RetroNoob2024 06/07/24, 10:37 pm

Thank you.

This https://github.com/batocera-linux/batocera-emulationstation as is without any code changes for Windows?
RetroNoob2024
RetroNoob2024

Messages : 4
Date d'inscription : 2024-07-06

Back to top Go down

Quality of life issues for Retrobat Empty Re: Quality of life issues for Retrobat

Post by tartifless 06/07/24, 11:02 pm

Yes, the one on the Retrobat repo is only to build it for windows.


Quality of life issues for Retrobat Admin4
tartifless
tartifless
Admin

Messages : 1674
Date d'inscription : 2021-04-27

Back to top Go down

Quality of life issues for Retrobat Empty Re: Quality of life issues for Retrobat

Post by RetroNoob2024 07/07/24, 07:12 pm

Thank you. I managed to get everything to compile, was a little painful but doable. Will share my small changes on my fork on github when I am done.

So for #2, I noticed that the code already had what I needed in theory with <linearSmooth>true</linearSmooth>

but when I add it to my theme into

<image name="md_image">
and into

<video name="md_video">

Unfortunately the filtering is not applied.

RetroNoob2024
RetroNoob2024

Messages : 4
Date d'inscription : 2024-07-06

Back to top Go down

Quality of life issues for Retrobat Empty Re: Quality of life issues for Retrobat

Post by RetroNoob2024 09/07/24, 07:07 am

tartifless wrote:Yes, the one on the Retrobat repo is only to build it for windows.

Thanks again. I made a fork making it easier for people to build on windows with simpler directions and with the changes I asked for regarding extensions case sensitivity and filtering in case anyone is interested.

https://github.com/Nitch2024/batocera-emulationstation
RetroNoob2024
RetroNoob2024

Messages : 4
Date d'inscription : 2024-07-06

Back to top Go down

Quality of life issues for Retrobat Empty Re: Quality of life issues for Retrobat

Post by Sponsored content


Sponsored content


Back to top Go down

Back to top

- Similar topics

 
Permissions in this forum:
You cannot reply to topics in this forum